Bug 171370

Summary:

Text gets cut off when bailing out of simple line layout with widows.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2017-04-27 02:49:47 PDT

rdar://problem/31563414

Comment 1 zalan 2017-04-27 02:56:19 PDT

Created attachment 308365 [details]
Patch

Comment 2 Antti Koivisto 2017-04-27 03:01:14 PDT

Comment on attachment 308365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308365&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:3737
> +        if (shouldBreakAtLineToAvoidWidow())
> +            layoutLineBoxes(relayoutChildren, repaintLogicalTop, repaintLogicalBottom);

Maybe add a comment here about how this matches relayoutToAvoidWidows?

Comment 3 zalan 2017-04-27 03:08:40 PDT

Created attachment 308368 [details]
Patch

Comment 4 WebKit Commit Bot 2017-04-27 04:02:12 PDT

Comment on attachment 308368 [details]
Patch

Clearing flags on attachment: 308368

Committed r215861: <http://trac.webkit.org/changeset/215861>

Comment 5 WebKit Commit Bot 2017-04-27 04:02:14 PDT

All reviewed patches have been landed.  Closing bug.