Bug 171350

Summary:

[WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, bfulgham, jiewen_tan, jonlee, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=162554

Attachments:

Description	Flags
Patch	bfulgham: review+, bfulgham: commit-queue-
Patch for landing	none

Jiewen Tan

Reported 2017-04-26 16:18:25 PDT

Add an api test for testing wrapping/unwrapping serialized crypto keys.

Attachments
Patch (15.67 KB, patch) 2017-04-26 16:25 PDT, Jiewen Tan	bfulgham: review+ bfulgham: commit-queue-	Details Formatted Diff Diff
Patch for landing (15.65 KB, patch) 2017-05-03 12:31 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jiewen Tan

Comment 1 2017-04-26 16:19:11 PDT

<rdar://problem/28600836>

Jiewen Tan

Comment 2 2017-04-26 16:25:05 PDT

Created attachment 308303 [details] Patch

Brent Fulgham

Comment 3 2017-05-03 09:04:14 PDT

Comment on attachment 308303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308303&action=review This looks good, but I think your test case is wrong in the openRequest.onerror handler. Can you please fix before landing? > Tools/TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html:49 > + finishJSTest(); There are no definitions for "testFailed" or "finishJSTest" in TestWebKitAPI -- I'm surprised this doesn't create an error when you run. Please remove these lines and switch to "alert("FAIL")" or something for these failure case.

Jiewen Tan

Comment 4 2017-05-03 12:16:24 PDT

Comment on attachment 308303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308303&action=review Thanks Brent for r+ the patch. >> Tools/TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html:49 >> + finishJSTest(); > > There are no definitions for "testFailed" or "finishJSTest" in TestWebKitAPI -- I'm surprised this doesn't create an error when you run. > > Please remove these lines and switch to "alert("FAIL")" or something for these failure case. I think that's because those code paths are never executed.

Jiewen Tan

Comment 5 2017-05-03 12:31:55 PDT

Created attachment 308939 [details] Patch for landing

Jiewen Tan

Comment 6 2017-05-03 16:50:52 PDT

Committed r216157: <http://trac.webkit.org/changeset/216157>

Note You need to log in before you can comment on or make changes to this bug.