Bug 171344

Summary: Audit and fix incorrect uses of JSArray::tryCreateForInitializationPrivate().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fpizlo, jfbastien, keith_miller, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
work in progress.
none
work in progress.
buildbot: commit-queue-
Archive of layout-test-results from ews114 for mac-elcapitan
none
proposed patch. fpizlo: review+

Description Mark Lam 2017-04-26 15:03:47 PDT
Patch coming.
Comment 1 Mark Lam 2017-04-26 15:04:06 PDT
<rdar://problem/31352667>
Comment 2 Mark Lam 2017-04-26 23:17:41 PDT
Created attachment 308347 [details]
work in progress.
Comment 3 Mark Lam 2017-04-26 23:42:42 PDT
Created attachment 308351 [details]
work in progress.
Comment 4 Build Bot 2017-04-27 01:08:13 PDT
Comment on attachment 308351 [details]
work in progress.

Attachment 308351 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3617461

New failing tests:
js/kde/Array.html
Comment 5 Build Bot 2017-04-27 01:08:15 PDT
Created attachment 308363 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Mark Lam 2017-04-27 10:42:38 PDT
Created attachment 308408 [details]
proposed patch.
Comment 7 Filip Pizlo 2017-04-27 12:17:28 PDT
Comment on attachment 308408 [details]
proposed patch.

This is really cool!
Comment 8 Mark Lam 2017-04-27 12:23:30 PDT
Comment on attachment 308408 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308408&action=review

> Source/JavaScriptCore/ChangeLog:24
> +           are meant for clients of WebKit.  In this case, we intend for use of this API

There's a typo here.  I meant to say "are not meant for clients of WebKit".  Will fix before landing.
Comment 9 Mark Lam 2017-04-27 12:25:36 PDT
Thanks for the review.  Landed in r215885: <http://trac.webkit.org/r215885>.