Bug 171329

Summary: Speedometer: Add a React + Redux TodoMVC implementation
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Addy Osmani 2017-04-26 09:24:06 PDT 
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), this tracks adding a TodoMVC implementation for React with Redux. Redux is popular with libraries like React because it lets you describe UI as a function of state, and Redux emits state updates in response to actions. Applications built using Redux demonstrate sufficiently different patterns to how a normal React app is crafted that it was worth including.
Comment 1 Addy Osmani 2017-04-26 09:42:20 PDT 
Created attachment 308260 [details]
Patch
Comment 2 Addy Osmani 2017-05-11 18:49:46 PDT 
Created attachment 309845 [details]
Patch
Comment 3 Addy Osmani 2017-05-11 18:51:09 PDT 
Per the other patches, I've made sure to add an extra line before the patch title and remove extraneous comments from the changelog.
Comment 4 Ryosuke Niwa 2017-05-11 19:15:13 PDT 
It looks like this patch doesn't apply on ToT. Would you mind rebasing against trunk?
Comment 5 Addy Osmani 2017-05-11 19:46:32 PDT 
Created attachment 309850 [details]
Patch
Comment 6 Addy Osmani 2017-05-11 19:47:04 PDT 
Re-submitted after rebasing against trunk. Let's see if it needs another round of work.
Comment 7 Addy Osmani 2017-05-11 20:35:18 PDT 
Created attachment 309859 [details]
Patch
Comment 8 WebKit Commit Bot 2017-05-11 22:50:37 PDT 
Comment on attachment 309859 [details]
Patch

Clearing flags on attachment: 309859

Committed r216732: <http://trac.webkit.org/changeset/216732>
Comment 9 WebKit Commit Bot 2017-05-11 22:50:38 PDT 
All reviewed patches have been landed.  Closing bug.