Bug 171296

Summary: [ARM] Enable GCC visibility
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
achristensen: review-, achristensen: commit-queue-
Patch with GCC 4 check removed none

Description Don Olmstead 2017-04-25 16:23:16 PDT 
The export macros for WebKit have a guard to prevent the GCC visibility attribute on ARM. This was originally done back in 2009 with https://trac.webkit.org/changeset/48251/webkit. It appears that armcc now supports the visibility attribute, http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0472j/chr1359124978628.html, so this can be enabled.
Comment 1 Don Olmstead 2017-04-25 17:05:39 PDT 
Created attachment 308169 [details]
Patch

Enables GCC visibility for armcc. GCC needs to be >= 4 to have support. Clang also exposes this macro.
Comment 2 Don Olmstead 2017-04-25 17:06:32 PDT 
This fixes the feedback from https://bugs.webkit.org/show_bug.cgi?id=171240 that wasn't gotten to before landing.
Comment 3 Alex Christensen 2017-04-26 00:33:57 PDT 
I don't think we support gcc older than 4.
Comment 4 Michael Catanzaro 2017-04-26 10:25:56 PDT 
(In reply to Alex Christensen from comment #3)
> I don't think we support gcc older than 4.

Yeah, GCC 4.0 was released in 2005 and there's no way to compile WebKit with anything less than GCC 4.9. We have checks to prevent this in other places. No need for that version test.
Comment 5 Alex Christensen 2017-04-26 10:40:00 PDT 
Comment on attachment 308169 [details]
Patch

Ok, that's what I thought.  Let's just remove the checks.
Comment 6 Don Olmstead 2017-04-26 10:43:17 PDT 
Created attachment 308265 [details]
Patch with GCC 4 check removed
Comment 7 WebKit Commit Bot 2017-04-26 11:28:04 PDT 
Comment on attachment 308265 [details]
Patch with GCC 4 check removed

Clearing flags on attachment: 308265

Committed r215817: <http://trac.webkit.org/changeset/215817>
Comment 8 WebKit Commit Bot 2017-04-26 11:28:06 PDT 
All reviewed patches have been landed.  Closing bug.