Bug 171294

Summary: Move mediaCaptureEnabled from WKWebViewConfiguration to WKPreferences
Product: WebKit Reporter: Andrew Gold <agold>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: agold, buildbot, commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch v2.
none
proposed patch v3.
eric.carlson: review+, eric.carlson: commit-queue-
proposed patch v4.
none
proposed patch 5 none

Andrew Gold
Reported 2017-04-25 14:47:03 PDT
Move the mediaCaptureEnabled setting from WKWebViewConfiguration to WKPreferences so that it can be toggled dynamically.
Attachments
proposed patch. (8.72 KB, patch)
2017-04-25 15:52 PDT, Andrew Gold 		no flags
DetailsFormatted DiffDiff
proposed patch v2. (8.72 KB, patch)
2017-04-25 15:55 PDT, Andrew Gold 		no flags
DetailsFormatted DiffDiff
proposed patch v3. (9.45 KB, patch)
2017-04-25 16:16 PDT, Andrew Gold 		eric.carlson: review+
eric.carlson: commit-queue-
DetailsFormatted DiffDiff
proposed patch v4. (8.71 KB, patch)
2017-04-26 08:20 PDT, Andrew Gold 		no flags
DetailsFormatted DiffDiff
proposed patch 5 (8.71 KB, patch)
2017-04-26 08:24 PDT, Andrew Gold 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andrew Gold
Comment 1 2017-04-25 14:47:18 PDT
rdar://problem/31817010
Andrew Gold
Comment 2 2017-04-25 15:52:29 PDT
Created attachment 308155 [details] proposed patch.
Build Bot
Comment 3 2017-04-25 15:53:37 PDT
Attachment 308155 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:19: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrew Gold
Comment 4 2017-04-25 15:55:31 PDT
Created attachment 308156 [details] proposed patch v2.
Andrew Gold
Comment 5 2017-04-25 16:16:10 PDT
Created attachment 308159 [details] proposed patch v3.
Jon Lee
Comment 6 2017-04-25 18:36:45 PDT
(In reply to Andrew Gold from comment #5) > Created attachment 308159 [details] > proposed patch v3. application/mbox?
Eric Carlson
Comment 7 2017-04-25 20:14:41 PDT
Comment on attachment 308159 [details] proposed patch v3. View in context: https://bugs.webkit.org/attachment.cgi?id=308159&action=review > Source/WebKit2/UIProcess/UserMediaProcessManager.cpp:-121 > -#if !PLATFORM(IOS) > if (&manager->page() == &pageStartingCapture) > continue; > -#endif Did you mean to include this?
Andrew Gold
Comment 8 2017-04-26 08:13:24 PDT
(In reply to Eric Carlson from comment #7) > Comment on attachment 308159 [details] > proposed patch v3. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308159&action=review > > > Source/WebKit2/UIProcess/UserMediaProcessManager.cpp:-121 > > -#if !PLATFORM(IOS) > > if (&manager->page() == &pageStartingCapture) > > continue; > > -#endif > > Did you mean to include this? I did not. I will upload a revised version.
Andrew Gold
Comment 9 2017-04-26 08:20:01 PDT
Created attachment 308248 [details] proposed patch v4.
Build Bot
Comment 10 2017-04-26 08:22:09 PDT
Attachment 308248 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:25: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrew Gold
Comment 11 2017-04-26 08:24:57 PDT
Created attachment 308249 [details] proposed patch 5
WebKit Commit Bot
Comment 12 2017-04-26 08:55:38 PDT
Comment on attachment 308249 [details] proposed patch 5 Clearing flags on attachment: 308249 Committed r215801: <http://trac.webkit.org/changeset/215801>
WebKit Commit Bot
Comment 13 2017-04-26 08:55:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.