Bug 171294

Summary:

Move mediaCaptureEnabled from WKWebViewConfiguration to WKPreferences

Product:

WebKit

Reporter:

Andrew Gold <agold>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agold, buildbot, commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	none
proposed patch v2.	none
proposed patch v3.	eric.carlson: review+, eric.carlson: commit-queue-
proposed patch v4.	none
proposed patch 5	none

Description Andrew Gold 2017-04-25 14:47:03 PDT

Move the mediaCaptureEnabled setting from WKWebViewConfiguration to WKPreferences so that it can be toggled dynamically.

Comment 1 Andrew Gold 2017-04-25 14:47:18 PDT

rdar://problem/31817010

Comment 2 Andrew Gold 2017-04-25 15:52:29 PDT

Created attachment 308155 [details]
proposed patch.

Comment 3 Build Bot 2017-04-25 15:53:37 PDT

Attachment 308155 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:19:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Andrew Gold 2017-04-25 15:55:31 PDT

Created attachment 308156 [details]
proposed patch v2.

Comment 5 Andrew Gold 2017-04-25 16:16:10 PDT

Created attachment 308159 [details]
proposed patch v3.

Comment 6 Jon Lee 2017-04-25 18:36:45 PDT

(In reply to Andrew Gold from comment #5)
> Created attachment 308159 [details]
> proposed patch v3.

application/mbox?

Comment 7 Eric Carlson 2017-04-25 20:14:41 PDT

Comment on attachment 308159 [details]
proposed patch v3.

View in context: https://bugs.webkit.org/attachment.cgi?id=308159&action=review

> Source/WebKit2/UIProcess/UserMediaProcessManager.cpp:-121
> -#if !PLATFORM(IOS)
>              if (&manager->page() == &pageStartingCapture)
>                  continue;
> -#endif

Did you mean to include this?

Comment 8 Andrew Gold 2017-04-26 08:13:24 PDT

(In reply to Eric Carlson from comment #7)
> Comment on attachment 308159 [details]
> proposed patch v3.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308159&action=review
> 
> > Source/WebKit2/UIProcess/UserMediaProcessManager.cpp:-121
> > -#if !PLATFORM(IOS)
> >              if (&manager->page() == &pageStartingCapture)
> >                  continue;
> > -#endif
> 
> Did you mean to include this?

I did not. I will upload a revised version.

Comment 9 Andrew Gold 2017-04-26 08:20:01 PDT

Created attachment 308248 [details]
proposed patch v4.

Comment 10 Build Bot 2017-04-26 08:22:09 PDT

Attachment 308248 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:25:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Andrew Gold 2017-04-26 08:24:57 PDT

Created attachment 308249 [details]
proposed patch 5

Comment 12 WebKit Commit Bot 2017-04-26 08:55:38 PDT

Comment on attachment 308249 [details]
proposed patch 5

Clearing flags on attachment: 308249

Committed r215801: <http://trac.webkit.org/changeset/215801>

Comment 13 WebKit Commit Bot 2017-04-26 08:55:39 PDT

All reviewed patches have been landed.  Closing bug.