Bug 171283

Summary: Web Inspector: "Space" localized string is not loaded in combined and minified builds
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-04-25 12:21:29 PDT
Summary: "Space" localized string is not loaded in combined and minified builds Steps to Reproduce: 1. Build and optimized build 2. Open inspector 3. Show Timeline Tab 4. Hover Record button => Localized string not found for "Space"
Attachments
[PATCH] Proposed Fix (6.45 KB, patch)
2017-04-25 12:24 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (6.45 KB, patch)
2017-04-25 12:25 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-04-25 12:21:38 PDT
<rdar://problem/30871371>
Joseph Pecoraro
Comment 2 2017-04-25 12:24:57 PDT
Created attachment 308127 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2017-04-25 12:25:47 PDT
Created attachment 308128 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 4 2017-04-25 13:01:35 PDT
Comment on attachment 308128 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=308128&action=review r=me > Source/WebInspectorUI/UserInterface/Models/Resource.js:694 > + console.assert(!isNaN(size), "Size should be a valid number."); This seems unrelated, but whatever. > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1782 > + console.assert(breakpointTreeElement, "Missing breakpoint descendant.", this); Ditto.
WebKit Commit Bot
Comment 5 2017-04-25 13:38:03 PDT
Comment on attachment 308128 [details] [PATCH] Proposed Fix Clearing flags on attachment: 308128 Committed r215755: <http://trac.webkit.org/changeset/215755>
WebKit Commit Bot
Comment 6 2017-04-25 13:38:05 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 7 2017-04-25 13:39:20 PDT
(In reply to Brian Burg from comment #4) > Comment on attachment 308128 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308128&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Models/Resource.js:694 > > + console.assert(!isNaN(size), "Size should be a valid number."); > > This seems unrelated, but whatever. These are explained in the changelog. They are warnings produced by the optimizer, which is related to this bug (an issue only seen in optimized builds).
Note You need to log in before you can comment on or make changes to this bug.