Bug 171281

Summary: Improve wavy underline rendering
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sam, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Dave Hyatt
Reported 2017-04-25 11:37:56 PDT
Improve wavy underline rendering
Attachments
Patch (5.63 KB, patch)
2017-04-25 11:40 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2017-04-25 11:40:00 PDT
Created attachment 308119 [details] Patch
Sam Weinig
Comment 2 2017-04-25 11:53:01 PDT
Comment on attachment 308119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308119&action=review I take it, the only real way to regression test this is pixel tests? > Source/WebCore/style/InlineTextBoxStyle.cpp:93 > // Distance between decoration's axis and Bezier curve's control points. > // The height of the curve is based on this distance. Use a minimum of 6 pixels distance since > // the actual curve passes approximately at half of that distance, that is 3 pixels. > // The minimum height of the curve is also approximately 3 pixels. Increases the curve's height > // as strokeThickness increases to make the curve look better. Is this comment still correct?
Dave Hyatt
Comment 3 2017-04-26 08:59:11 PDT
Fixed in r215802.
Note You need to log in before you can comment on or make changes to this bug.