Bug 171270 – [GTK] Add libgpg-error, libgcrypt libraries to JHBuild

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[GTK] Add libgpg-error, libgcrypt libraries to JHBuild

[Zan Dobersek]

Created attachment 308094 [details]
Patch

[Zan Dobersek]

Created attachment 308098 [details]
Patch

[Michael Catanzaro]

Comment on attachment 308098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308098&action=review

> Tools/ChangeLog:20
> [phone]  Zan Dobersek  <[e-mail]>
> +
> +        [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
> +        https://bugs.webkit.org/show_bug.cgi?id=171270
> +
> +        Reviewed by NOBODY (OOPS!).

Remove this duplicate changelog entry!

> Tools/gtk/jhbuild.modules:621
> +    <dependencies>
> +      <dep package="libgpg-error"/>
> +    </dependencies>

Style: put the branch tag first, then the dependencies tag next.

> Tools/gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch:12
> ++  // Enforce the use of /dev/urandom for testing of the libgcrypt-based
> ++  // Web Crypto implementation testing in WebKit.
> ++  // DO NOT USE THIS PATCH OUTSIDE OF TESTING ENVIRONMENTS.
> ++  level = 0;

Nice!

[Zan Dobersek]

Committed r215739: <http://trac.webkit.org/changeset/215739>