Bug 171267

Summary: [GTK] Remote inspector should support inspecting targets with previous version of backend commands
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, don.olmstead, joepeck, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-04-25 03:13:42 PDT
There's a FIXME for this in the code. The remote inspector proxy allows to pass a backend commands URL when inspecting a target. That URL is not empty is used as Protocol/InspectorBackendCommands.js in the inspector instead of the local copy. We are currently assuming that both ends use the same version of that file.
Attachments
Patch (18.31 KB, patch)
2017-04-25 03:29 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-04-25 03:29:25 PDT
Created attachment 308081 [details] Patch I'm using SHA1, and not SHA256, to compute the backend commands hash because we don't have access to PAL from JavaScriptCore.
Carlos Garcia Campos
Comment 2 2017-04-27 05:28:58 PDT
Committed r215862: <http://trac.webkit.org/changeset/215862>
Don Olmstead
Comment 3 2017-04-27 09:56:52 PDT
(In reply to Carlos Garcia Campos from comment #1) > Created attachment 308081 [details] > Patch > > I'm using SHA1, and not SHA256, to compute the backend commands hash because > we don't have access to PAL from JavaScriptCore. Should we move those things into WTF?
Note You need to log in before you can comment on or make changes to this bug.