Bug 171253

Summary: Web Inspector: Open the new bug page in the new tab
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
joepeck: review+
Patch
commit-queue: commit-queue-
Patch none

Nikita Vasilyev
Reported 2017-04-24 16:20:35 PDT
Opening in the new tab would be better than leaving the page I'm debugging.
Attachments
Patch (1.75 KB, patch)
2017-04-24 16:21 PDT, Nikita Vasilyev 		joepeck: review+
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2017-04-25 11:47 PDT, Nikita Vasilyev 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2017-04-25 11:53 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2017-04-24 16:21:16 PDT
Created attachment 308020 [details] Patch
Joseph Pecoraro
Comment 2 2017-04-24 19:06:50 PDT
Comment on attachment 308020 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308020&action=review r=me > Source/WebInspectorUI/ChangeLog:10 > + (sheetElement.innerHTML.div): > + (let.dismissOptionHTML.loadCompleted.string_appeared_here.dt.A.frivolous.exception.will.not.stop.me.dt.dd.a): Err, these ChangeLog lines don't look right. Better to remove them when they look like this.
Nikita Vasilyev
Comment 3 2017-04-25 11:47:32 PDT
Created attachment 308121 [details] Patch
WebKit Commit Bot
Comment 4 2017-04-25 11:48:21 PDT
Comment on attachment 308121 [details] Patch Rejecting attachment 308121 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 308121, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Processing patch 308121 from bug 171253. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog patch: **** malformed patch at line 18: patching file Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3603134
Nikita Vasilyev
Comment 5 2017-04-25 11:53:17 PDT
Created attachment 308123 [details] Patch
WebKit Commit Bot
Comment 6 2017-04-25 12:48:07 PDT
The commit-queue encountered the following flaky tests while processing attachment 308123 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2017-04-25 14:13:00 PDT
Comment on attachment 308123 [details] Patch Clearing flags on attachment: 308123 Committed r215757: <http://trac.webkit.org/changeset/215757>
WebKit Commit Bot
Comment 8 2017-04-25 14:13:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.