Bug 171236

Summary: Relax the event firing ASSERT for Attr changes
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, buildbot, cdumez, cmarcelo, commit-queue, dbates, ddkilzer, dino, esprehn+autocc, kangil.han, kling, koivisto, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Brent Fulgham
Reported 2017-04-24 11:48:01 PDT
In Bug 167318 we added assertions to help us recognize when events were being dispatched at inappropriate times. These assertions were overly-strict, and are firing for some cases where we expect events to be triggered. This Bug relaxes the assertion for the case of an Attribute being modified, which must send style change notifications.
Attachments
Patch (6.20 KB, patch)
2017-04-25 14:45 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.28 KB, patch)
2017-04-25 18:45 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2017-04-24 11:48:12 PDT
<rdar://problem/30516349>
Brent Fulgham
Comment 2 2017-04-25 14:45:55 PDT
Created attachment 308148 [details] Patch
Dean Jackson
Comment 3 2017-04-25 18:43:42 PDT
Comment on attachment 308148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308148&action=review > Source/WebCore/dom/ContainerNode.cpp:72 > #ifndef NDEBUG You use !ASSERT_DISABLED in the .h file.
Brent Fulgham
Comment 4 2017-04-25 18:45:50 PDT
Created attachment 308186 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-04-25 19:26:08 PDT
Comment on attachment 308186 [details] Patch for landing Clearing flags on attachment: 308186 Committed r215787: <http://trac.webkit.org/changeset/215787>
WebKit Commit Bot
Comment 6 2017-04-25 19:26:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.