Summary: | [GTK] Libgcrypt warning: missing initialization - please fix the application | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, buildbot, jiewen_tan, mcatanzaro, zan | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2017-04-24 10:23:12 PDT
I think the original warning was fixed in bug #173589. But now we have a new one: Sep 01 08:57:53 victory-road WebKitNetworkProcess[20806]: Libgcrypt warning: missing initialization - please fix the application Seems like it's needed in network process too. Most likely this is occurring due to PAL::CryptoDigest use in SoupNetworkSession. Created attachment 319718 [details]
Patch
Comment on attachment 319718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319718&action=review Thanks! > Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:56 > +#if USE(GCRYPT) > + // Call gcry_check_version() before any other libgcrypt call, ignoring the > + // returned version string. > + gcry_check_version(nullptr); > + > + // Pre-allocate 16kB of secure memory and finish the initialization. > + gcry_control(GCRYCTL_INIT_SECMEM, 16384, nullptr); > + gcry_control(GCRYCTL_INITIALIZATION_FINISHED, nullptr); > +#endif We should move this down to PAL so we don't have to duplicate it in multiple places. Probably time to add a Source/WebCore/PAL/pal/crypto/gcrypt/Utilities.cpp. Created attachment 319737 [details]
Patch
Thanks. Please add it to https://trac.webkit.org/wiki/WebKitGTK/2.18.x after you land it. Comment on attachment 319737 [details] Patch Clearing flags on attachment: 319737 Committed r221572: <http://trac.webkit.org/changeset/221572> All reviewed patches have been landed. Closing bug. |