Bug 171218
| Summary: | REGRESSION(r215088): [GTK] Memory peak on perf test Animation/Balls.html is a 20% higher. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, zan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://perf.webkit.org/v3/#/charts?since=1491140313418&paneList=%28%2816-194%29-%2816-92%29%29&repository=1 | ||
| Bug Depends on: | |||
| Bug Blocks: | 170457 | ||
Carlos Alberto Lopez Perez
The maximum resident memory on the perf test Animation/Balls.html grew from 119MB to 141MB after r215088 <https://trac.webkit.org/r215088>
At the same time, the JSHeap memory shrinked from 1.12MB to 0Bytes.
https://perf.webkit.org/v3/#/charts?since=1491140313418&paneList=%28%2816-194%29-%2816-92%29%29&repository=1
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Zan Dobersek
Probably due to the change in priority of the JSRunLoopTimer. It was G_PRIORITY_DEFAULT before (0), now it's been raised to 200, which is the highest value in the RunLooopSourcePriority enum.
Carlos Garcia Campos
Just to clarify, highest value which means lowest priority. The idea of that change was to give lower priorities to sources used to releases resource, like garbage collector. The memory pressure has the highest priority because in that case releasing resources is urgent. So, I'm not sure this is a problem.