Bug 171191

Summary: Address some FIXMEs in JavaScript tests for bugs that have been fixed
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, jfbastien, joepeck, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-04-23 00:03:42 PDT
Address some FIXMEs in JavaScript tests for bugs that have been fixed
Attachments
[PATCH] Proposed Fix (5.69 KB, patch)
2017-04-23 00:04 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (117.73 KB, patch)
2017-04-23 00:13 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-04-23 00:04:31 PDT
Created attachment 307922 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2017-04-23 00:13:40 PDT
Created attachment 307924 [details] [PATCH] Proposed Fix Fixed style issues. Good for review.
Saam Barati
Comment 3 2017-04-23 09:54:14 PDT
Comment on attachment 307924 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 4 2017-04-23 10:23:07 PDT
Comment on attachment 307924 [details] [PATCH] Proposed Fix Clearing flags on attachment: 307924 Committed r215674: <http://trac.webkit.org/changeset/215674>
WebKit Commit Bot
Comment 5 2017-04-23 10:23:08 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2017-04-23 22:49:42 PDT
Reopening the bug and correcting the patch that is up for review. I put a different bug's patch on here by mistake. Original patch still reviewable.
JF Bastien
Comment 7 2017-04-24 09:36:38 PDT
Comment on attachment 307922 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 8 2017-04-24 11:09:00 PDT
Comment on attachment 307922 [details] [PATCH] Proposed Fix Clearing flags on attachment: 307922 Committed r215688: <http://trac.webkit.org/changeset/215688>
WebKit Commit Bot
Comment 9 2017-04-24 11:09:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.