Bug 17118
| Summary: | kjs_navigator.cpp should be re-written to be less crazy | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | andersca, ddkilzer, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
kjs_navigator.cpp should be re-written to be less crazy
kjs_navigator uses a complicated/hacky memory management scheme and thus I bet leaks in some cases.
Better would be for PluginBase to hold a reference to some PluginInfoCache static. When the PluginInfoCache ref count drops to 0, it can clear its caches. Those caches can use Vector<OwnPtr> to avoid ever leaking.
This could/should also be re-written to use the bindings autogen system. Thus Navigator would become a normal RefCounted class, and Navigator.idl would take care of all the details.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Can this bug be closed? I know Navigator.h/cpp/idl were created a while ago, and the plugin code has undergone many refactorings since this was filed.