Bug 171176

Summary:

[ATK] atk_table_cell_get_position() should return values of aria-rowindex and aria-colindex, if present

Product:

WebKit

Reporter:

Joanmarie Diggs <jdiggs>

Component:

Accessibility

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, akkaran046, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
Patch	none

Description Joanmarie Diggs 2017-04-22 16:46:24 PDT

For ATK, support for aria-rowindex and aria-colindex requires:
1. Expose the values via the "rowindex" and "colindex" object attributes
2. Returning the values via atk_table_cell_get_position()

See:
* https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaColIndex
* https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaRowIndex

Comment 1 Radar WebKit Bug Importer 2017-04-22 16:46:41 PDT

<rdar://problem/31775666>

Comment 2 Joanmarie Diggs 2017-05-04 08:49:28 PDT

Updating the summary because the object attributes are already done.

Comment 3 Joanmarie Diggs 2017-09-26 11:39:52 PDT

Created attachment 321851 [details]
Patch

Comment 4 chris fleizach 2017-09-26 17:53:44 PDT

Comment on attachment 321851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321851&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:126
> +            rowIndex = columnRowRange.first;

this should be columRowRange.second right?

Comment 5 Joanmarie Diggs 2017-09-26 18:00:53 PDT

(In reply to chris fleizach from comment #4)
> Comment on attachment 321851 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321851&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:126
> > +            rowIndex = columnRowRange.first;
> 
> this should be columRowRange.second right?

The index/location is the range's first; the span/length is its second.

Comment 6 WebKit Commit Bot 2017-09-27 02:45:39 PDT

Comment on attachment 321851 [details]
Patch

Clearing flags on attachment: 321851

Committed r222551: <http://trac.webkit.org/changeset/222551>

Comment 7 WebKit Commit Bot 2017-09-27 02:45:40 PDT

All reviewed patches have been landed.  Closing bug.