Bug 171175

Summary: [ATK] Expose value of aria-keyshortcuts as object attribute
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cdumez, cfleizach, commit-queue, dmazzoni, esprehn+autocc, gyuyoung.kim, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Comment 1 Radar WebKit Bug Importer 2017-04-22 16:22:16 PDT
<rdar://problem/31775615>
Comment 2 Joanmarie Diggs 2017-10-10 21:43:39 PDT
Created attachment 323384 [details]
Patch
Comment 3 chris fleizach 2017-10-10 23:15:21 PDT
Comment on attachment 323384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323384&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605
> +    String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr);

can we plumb this through AccessibilityObject?
Comment 4 Joanmarie Diggs 2017-10-10 23:30:00 PDT
(In reply to chris fleizach from comment #3)
> Comment on attachment 323384 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323384&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605
> > +    String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr);
> 
> can we plumb this through AccessibilityObject?

We could. But I was going for the minimal amount of change given what was stated in bug 159215 (i.e. doubts about what support for this new ARIA feature would entail).

If we do add support in AccessibilityObject, should we just return the value as-is, or convert it to a Vector as was done for AccessibilityRenderObject::determineARIADropEffects()?
Comment 5 chris fleizach 2017-10-10 23:39:31 PDT
Comment on attachment 323384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323384&action=review

>>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605
>>> +    String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr);
>> 
>> can we plumb this through AccessibilityObject?
> 
> We could. But I was going for the minimal amount of change given what was stated in bug 159215 (i.e. doubts about what support for this new ARIA feature would entail).
> 
> If we do add support in AccessibilityObject, should we just return the value as-is, or convert it to a Vector as was done for AccessibilityRenderObject::determineARIADropEffects()?

I think probably just a pass through for the time being
Comment 6 Joanmarie Diggs 2017-10-11 01:37:03 PDT
Created attachment 323397 [details]
Patch
Comment 7 WebKit Commit Bot 2017-10-11 10:04:46 PDT
Comment on attachment 323397 [details]
Patch

Clearing flags on attachment: 323397

Committed r223190: <https://trac.webkit.org/changeset/223190>
Comment 8 WebKit Commit Bot 2017-10-11 10:04:48 PDT
All reviewed patches have been landed.  Closing bug.