Summary: | [ATK] Expose value of aria-keyshortcuts as object attribute | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||||
Component: | Accessibility | Assignee: | Joanmarie Diggs <jdiggs> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cdumez, cfleizach, commit-queue, dmazzoni, esprehn+autocc, gyuyoung.kim, jcraig, samuel_white, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Joanmarie Diggs
2017-04-22 16:22:02 PDT
Created attachment 323384 [details]
Patch
Comment on attachment 323384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323384&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605 > + String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr); can we plumb this through AccessibilityObject? (In reply to chris fleizach from comment #3) > Comment on attachment 323384 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323384&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605 > > + String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr); > > can we plumb this through AccessibilityObject? We could. But I was going for the minimal amount of change given what was stated in bug 159215 (i.e. doubts about what support for this new ARIA feature would entail). If we do add support in AccessibilityObject, should we just return the value as-is, or convert it to a Vector as was done for AccessibilityRenderObject::determineARIADropEffects()? Comment on attachment 323384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323384&action=review >>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:605 >>> + String keyShortcuts = coreObject->getAttribute(HTMLNames::aria_keyshortcutsAttr); >> >> can we plumb this through AccessibilityObject? > > We could. But I was going for the minimal amount of change given what was stated in bug 159215 (i.e. doubts about what support for this new ARIA feature would entail). > > If we do add support in AccessibilityObject, should we just return the value as-is, or convert it to a Vector as was done for AccessibilityRenderObject::determineARIADropEffects()? I think probably just a pass through for the time being Created attachment 323397 [details]
Patch
Comment on attachment 323397 [details] Patch Clearing flags on attachment: 323397 Committed r223190: <https://trac.webkit.org/changeset/223190> All reviewed patches have been landed. Closing bug. |