Summary: | [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||
Component: | Accessibility | Assignee: | Joanmarie Diggs <jdiggs> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, samuel_white, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Joanmarie Diggs
2017-04-22 12:31:08 PDT
Created attachment 308674 [details]
Patch
Comment on attachment 308674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308674&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:650 > + case TreeGridRole: will need to update this method too - (AccessibilityObjectWrapper*)_accessibilityTableAncestor { if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) { return object.roleValue() == TableRole || object.roleValue() == GridRole; })) return parent->wrapper(); return nil; } Comment on attachment 308674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308674&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:581 > + return object.isTable(); Chris: Isn't the above the change you're asking me to make in your review? Otherwise, I'm suffering from grepfail. >> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:650 >> + case TreeGridRole: > > will need to update this method too > > - (AccessibilityObjectWrapper*)_accessibilityTableAncestor > { > > if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) { > return object.roleValue() == TableRole || object.roleValue() == GridRole; > })) > return parent->wrapper(); > return nil; > } Please see above (I think I already did). Comment on attachment 308674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308674&action=review >> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:581 >> + return object.isTable(); > > Chris: Isn't the above the change you're asking me to make in your review? Otherwise, I'm suffering from grepfail. ah sorry! Comment on attachment 308674 [details] Patch Clearing flags on attachment: 308674 Committed r215988: <http://trac.webkit.org/changeset/215988> All reviewed patches have been landed. Closing bug. |