Bug 171144

Summary: Follow up with SharedBuffer changes after r215608
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+, commit-queue: commit-queue-

Alex Christensen
Reported 2017-04-21 15:13:37 PDT
Follow up with SharedBuffer changes after r215608
Attachments
Patch (24.53 KB, patch)
2017-04-21 15:22 PDT, Alex Christensen 		ggaren: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-04-21 15:22:58 PDT
Created attachment 307817 [details] Patch
Geoffrey Garen
Comment 2 2017-04-21 15:58:55 PDT
Comment on attachment 307817 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-04-21 20:07:18 PDT
Comment on attachment 307817 [details] Patch Rejecting attachment 307817 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 307817, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .mm Hunk #1 FAILED at 180. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm.rej patching file Source/WebCore/xml/XMLHttpRequest.cpp patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3581192
Alex Christensen
Comment 4 2017-04-24 10:39:28 PDT
I just incorporated these changes into the latest version of https://bugs.webkit.org/show_bug.cgi?id=170956
Note You need to log in before you can comment on or make changes to this bug.