Bug 171132

Summary: Regression(r206240): XMLSerializer.serializeToString() does not properly escape '<' / '>' in attribute values
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162356    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-04-21 12:50:34 PDT
XMLSerializer.serializeToString() does not properly escape '<' / '>' in attribute values after r206240, when the node's associated document is an HTMLDocument.
Attachments
Patch (27.05 KB, patch)
2017-04-21 12:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (27.03 KB, patch)
2017-04-21 14:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-04-21 12:50:49 PDT
<rdar://problem/31426752>
Chris Dumez
Comment 2 2017-04-21 12:59:03 PDT
Created attachment 307777 [details] Patch
Ryosuke Niwa
Comment 3 2017-04-21 14:39:24 PDT
Comment on attachment 307777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307777&action=review > Source/WebCore/ChangeLog:9 > + Test: fast/dom/XMLSerializer-serializeToString-entities.html This line should appear after [1] followed by a blank line before the first per-line comment appears. > Source/WebCore/editing/MarkupAccumulator.cpp:217 > -void MarkupAccumulator::appendAttributeValue(StringBuilder& result, const String& attribute, bool documentIsHTML) > +void MarkupAccumulator::appendAttributeValue(StringBuilder& result, const String& attribute, bool isHTMLSerialization) I would have called this isSerializingHTML or simply isHTML instead. Better, we could have changed this boolean to enum named MarkupSerializationMode or something.
Chris Dumez
Comment 4 2017-04-21 14:45:20 PDT
Created attachment 307812 [details] Patch
WebKit Commit Bot
Comment 5 2017-04-21 15:23:14 PDT
Comment on attachment 307812 [details] Patch Clearing flags on attachment: 307812 Committed r215648: <http://trac.webkit.org/changeset/215648>
WebKit Commit Bot
Comment 6 2017-04-21 15:23:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.