Bug 171124

Summary: Make AudioSampleBufferList::reset() less expensive.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Jer Noble
Reported 2017-04-21 11:24:38 PDT
Make AudioSampleBufferList::reset() less expensive.
Attachments
Patch (10.08 KB, patch)
2017-04-21 11:28 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (10.09 KB, patch)
2017-04-21 11:44 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-04-21 11:28:58 PDT
Created attachment 307757 [details] Patch
Eric Carlson
Comment 2 2017-04-21 11:31:36 PDT
Comment on attachment 307757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307757&action=review > Source/WebCore/platform/audio/WebAudioBufferList.cpp:45 > + m_pristineList = std::unique_ptr<AudioBufferList>(static_cast<AudioBufferList*>(::operator new (m_listBufferSize))); Nit: maybe m_canonicalList?
Jer Noble
Comment 3 2017-04-21 11:44:47 PDT
Created attachment 307761 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-04-21 12:22:50 PDT
Comment on attachment 307761 [details] Patch for landing Clearing flags on attachment: 307761 Committed r215624: <http://trac.webkit.org/changeset/215624>
Note You need to log in before you can comment on or make changes to this bug.