Bug 171107

Summary: Web Automation: generate resizeWindowOfBrowsingContext and moveWindowOfBrowsingContext for all platforms
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 171431    
Attachments:
Description Flags
Patch none

Description Carlos Garcia Campos 2017-04-21 02:10:45 PDT 
The implementation is actually cross-platform, so it could be moved from WebAutomationSessionMac.mm to WebAutomationSession.cpp and simply return a NotImplemented error for iOS. This will allow to use these methods in other platforms.
Comment 1 Carlos Garcia Campos 2017-04-21 02:12:14 PDT 
Created attachment 307713 [details]
Patch
Comment 2 BJ Burg 2017-04-21 10:27:17 PDT 
Comment on attachment 307713 [details]
Patch

r=me, but please ping me on IRC when you land this. It might break internal things.
Comment 3 Carlos Garcia Campos 2017-04-21 23:25:01 PDT 
(In reply to Brian Burg from comment #2)
> Comment on attachment 307713 [details]
> Patch
> 
> r=me, but please ping me on IRC when you land this. It might break internal
> things.

Thanks, in that case it's probably better if you cq+ it :-)
Comment 4 BJ Burg 2017-05-02 07:04:24 PDT 
Comment on attachment 307713 [details]
Patch

Apple-internal projects build with this patch applied, setting cq+.
Comment 5 WebKit Commit Bot 2017-05-02 07:34:01 PDT 
Comment on attachment 307713 [details]
Patch

Clearing flags on attachment: 307713

Committed r216070: <http://trac.webkit.org/changeset/216070>
Comment 6 WebKit Commit Bot 2017-05-02 07:34:02 PDT 
All reviewed patches have been landed.  Closing bug.