Bug 171095

Summary: [MediaCapture][iOS] AVAudioSession must be active and the correct category before IO AudioUnits start producing data.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 171168    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2017-04-20 19:08:44 PDT
[MediaCapture][iOS] AVAudioSession must be active and the correct category before IO AudioUnits start producing data.
Attachments
Patch (6.92 KB, patch)
2017-04-20 19:19 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-04-20 19:19:25 PDT
Created attachment 307681 [details] Patch
youenn fablet
Comment 2 2017-04-20 20:11:20 PDT
Comment on attachment 307681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307681&action=review > Source/WebCore/Modules/mediastream/MediaStream.cpp:448 > + if (m_private->hasAudio() && m_isProducingData && m_private->hasCaptureAudioSource()) It would seem logic to have m_private->hasAudio() if m_private->hasCaptureAudioSource(). Is there a redundant check?
WebKit Commit Bot
Comment 3 2017-04-21 12:59:10 PDT
Comment on attachment 307681 [details] Patch Clearing flags on attachment: 307681 Committed r215626: <http://trac.webkit.org/changeset/215626>
WebKit Commit Bot
Comment 4 2017-04-21 12:59:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.