Bug 171067

Summary: Add CompletionHandlerCallChecker to SPI added in r215545
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, mitz, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review+, buildbot: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Brady Eidson
Reported 2017-04-20 12:06:51 PDT
Add CompletionHandlerCallChecker to SPI added in r215545 https://trac.webkit.org/changeset/215545/webkit
Attachments
Patch (7.08 KB, patch)
2017-04-20 12:08 PDT, Brady Eidson 		mitz: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (847.05 KB, application/zip)
2017-04-20 13:31 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-04-20 12:08:44 PDT
Created attachment 307610 [details] Patch
Build Bot
Comment 2 2017-04-20 12:10:34 PDT
Attachment 307610 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:152: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:152: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2017-04-20 13:31:16 PDT
Comment on attachment 307610 [details] Patch Attachment 307610 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3571515 New failing tests: webrtc/datachannel/bufferedAmountLowThreshold.html
Build Bot
Comment 4 2017-04-20 13:31:17 PDT
Created attachment 307630 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Brady Eidson
Comment 5 2017-04-20 13:51:32 PDT
(In reply to Build Bot from comment #3) > Comment on attachment 307610 [details] > Patch > > Attachment 307610 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/3571515 > > New failing tests: > webrtc/datachannel/bufferedAmountLowThreshold.html This is definitely not due to this patch.
Brady Eidson
Comment 6 2017-04-20 13:55:00 PDT
https://trac.webkit.org/changeset/215577/webkit
Note You need to log in before you can comment on or make changes to this bug.