Bug 171040

Summary:

AX: FKA: Buttons need a visible focus indicator

Product:

WebKit

Reporter:

Aaron Chu <aaron_chu>

Component:

Accessibility

Assignee:

Aaron Chu <aaron_chu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, graouts, jcraig, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 10

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

174906

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Patch	none

Aaron Chu

Reported 2017-04-19 22:17:08 PDT

<rdar://problem/30922548>

Attachments
Patch (6.00 KB, patch) 2017-04-19 22:19 PDT, Aaron Chu	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews112 for mac-elcapitan (1.93 MB, application/zip) 2017-04-19 23:25 PDT, Build Bot	no flags	Details
Patch (6.00 KB, patch) 2017-04-20 00:09 PDT, Aaron Chu	no flags	Details Formatted Diff Diff
Patch (6.04 KB, patch) 2017-04-21 14:21 PDT, Aaron Chu	no flags	Details Formatted Diff Diff
Patch (6.50 KB, patch) 2017-07-28 11:31 PDT, Aaron Chu	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (983.49 KB, application/zip) 2017-07-28 12:33 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.75 MB, application/zip) 2017-07-28 12:56 PDT, Build Bot	no flags	Details
Patch (7.20 KB, patch) 2017-07-28 15:36 PDT, Aaron Chu	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Aaron Chu

Comment 1 2017-04-19 22:19:54 PDT

Created attachment 307554 [details] Patch

Build Bot

Comment 2 2017-04-19 23:25:43 PDT

Comment on attachment 307554 [details] Patch Attachment 307554 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3568052 New failing tests: media/modern-media-controls/icon-button/icon-button-focus-state.html

Build Bot

Comment 3 2017-04-19 23:25:44 PDT

Created attachment 307562 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Aaron Chu

Comment 4 2017-04-20 00:09:49 PDT

Created attachment 307568 [details] Patch

Antoine Quint

Comment 5 2017-04-20 01:43:24 PDT

What happens when a button in the "on" state, such as the AirPlay button when playing the media through AirPlay, is also focused?

Aaron Chu

Comment 6 2017-04-20 13:07:35 PDT

It seems the existing "-apple-wireless-playback-target-active" is still used. Is the AirPlay button the only one that has an active state? I would like to suggest considering using the "active" state as the "on" state. When active (pressed), the button turns white, and so if the click persists it is reasonable for it to remain its background color (white), which can free up the blue to be used as focus state. Perhaps this is something we can consult HI?

James Craig

Comment 7 2017-04-21 11:40:09 PDT

(In reply to Aaron Chu from comment #6) > Perhaps this is something we can consult HI? Let's get it in working order so that HI has something to try out in the builds. If someone want additional changes, those can be in a follow-up bug. Let's don't gate the core functionality on a potential review that may be delayed.

Aaron Chu

Comment 8 2017-04-21 14:21:56 PDT

Created attachment 307805 [details] Patch

WebKit Commit Bot

Comment 9 2017-04-21 16:58:55 PDT

Comment on attachment 307805 [details] Patch Clearing flags on attachment: 307805 Committed r215652: <http://trac.webkit.org/changeset/215652>

WebKit Commit Bot

Comment 10 2017-04-21 16:58:57 PDT

All reviewed patches have been landed. Closing bug.

Aaron Chu

Comment 11 2017-07-28 11:26:04 PDT

This seems no longer exist anymore in the code base.

Aaron Chu

Comment 12 2017-07-28 11:31:44 PDT

Created attachment 316659 [details] Patch

Build Bot

Comment 13 2017-07-28 12:33:34 PDT

Comment on attachment 316659 [details] Patch Attachment 316659 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4203895 New failing tests: media/modern-media-controls/button/button-focus-state.html

Build Bot

Comment 14 2017-07-28 12:33:35 PDT

Created attachment 316668 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 15 2017-07-28 12:56:53 PDT

Comment on attachment 316659 [details] Patch Attachment 316659 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4203919 New failing tests: media/modern-media-controls/button/button-focus-state.html

Build Bot

Comment 16 2017-07-28 12:56:54 PDT

Created attachment 316670 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Aaron Chu

Comment 17 2017-07-28 15:36:29 PDT

Created attachment 316678 [details] Patch

WebKit Commit Bot

Comment 18 2017-07-29 03:00:38 PDT

Comment on attachment 316678 [details] Patch Clearing flags on attachment: 316678 Committed r220041: <http://trac.webkit.org/changeset/220041>

WebKit Commit Bot

Comment 19 2017-07-29 03:00:39 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.