Bug 171001

Summary: Another deadlock in CoreAudioCaptureSource
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED ---    
Severity: Normal CC: commit-queue, jer.noble, jonlee, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Patch for landing. none

Description Eric Carlson 2017-04-19 11:30:00 PDT 
Fix deadlock in CoreAudioCaptureSource and address comments missed in the review of bug 170771.
Comment 1 Radar WebKit Bug Importer 2017-04-19 11:31:39 PDT 
<rdar://problem/31712568>
Comment 2 Eric Carlson 2017-04-19 11:38:18 PDT 
Created attachment 307494 [details]
Proposed patch.
Comment 3 youenn fablet 2017-04-19 12:21:00 PDT 
Comment on attachment 307494 [details]
Proposed patch.

r=me with small change discussed directly
Comment 4 Eric Carlson 2017-04-19 12:49:12 PDT 
Created attachment 307499 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2017-04-19 13:43:04 PDT 
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, mitz@webkit.org, rniwa@webkit.org, and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2017-04-19 13:43:05 PDT 
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-04-19 14:24:23 PDT 
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2017-04-19 14:24:24 PDT 
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2017-04-19 15:05:53 PDT 
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2017-04-19 15:05:54 PDT 
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2017-04-19 16:36:39 PDT 
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2017-04-19 16:36:58 PDT 
The commit-queue encountered the following flaky tests while processing attachment 307499 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2017-04-19 17:53:40 PDT 
Comment on attachment 307499 [details]
Patch for landing.

Clearing flags on attachment: 307499

Committed r215546: <http://trac.webkit.org/changeset/215546>