Bug 170977

Summary:

[GTK] Web Inspector: some SVG images are specified 'currentColor' incorrectly

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

Web Inspector

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, cgarcia, commit-queue, inspector-bugzilla-changes, joepeck, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
A screenshot of before and after	none
Patch	none
Patch	none
screenshot of before and after this fix	none

Fujii Hironori

Reported 2017-04-18 19:30:03 PDT

[GTK] Web Inspector: some SVG images are specified 'currentColor' incorrectly The keyword 'currentColor' is specifed manually in Bug 150602. But, some SVG images are specified unexpectedly. gtk/NavigationItemCurleyBraces.svg gtk/NavigationItemTypes.svg gtk/UpDownArrows.svg And, gtk/NavigationItemCurleyBraces.svg is licensed under NonCommercial CC (Bug 170902). I'll recreate this image.

Attachments
Patch (9.37 KB, patch) 2017-04-18 19:39 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
A screenshot of before and after (28.08 KB, image/png) 2017-04-18 19:40 PDT, Fujii Hironori	no flags	Details
Patch (10.04 KB, patch) 2017-04-19 22:19 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (6.60 KB, patch) 2017-04-26 21:21 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
screenshot of before and after this fix (53.95 KB, image/png) 2017-04-26 21:51 PDT, Fujii Hironori	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2017-04-18 19:39:18 PDT

Created attachment 307452 [details] Patch

Fujii Hironori

Comment 2 2017-04-18 19:40:04 PDT

Created attachment 307455 [details] A screenshot of before and after

Michael Catanzaro

Comment 3 2017-04-18 20:15:24 PDT

Could you please split this into two patches: * First patch to fix currentColor * Second patch, in bug #170902, to replace gtk/NavigationItemCurleyBraces.svg with the new version created by you. Thanks a bunch for fixing these issues. Also thanks for the screenshot, as that makes reviewing it much easier.

Fujii Hironori

Comment 4 2017-04-19 22:19:45 PDT

Created attachment 307553 [details] Patch Sure.

Joseph Pecoraro

Comment 5 2017-04-19 22:41:54 PDT

Comment on attachment 307553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307553&action=review > Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCurleyBraces.svg:-2 > - This removes the license that all the others have. Unexpected?

Fujii Hironori

Comment 6 2017-04-19 23:18:41 PDT

Umm, I should address Bug 170902 before this? Any idea, Michael?

Michael Catanzaro

Comment 7 2017-04-20 09:49:33 PDT

Please use CC-BY-SA for your new image, yes. And let's land a patch for that image in bug #170902 instead, yes. We shouldn't bury the fix for that in this issue. Perhaps you could upload a new patch here with the changes to just the other two icons.

Fujii Hironori

Comment 8 2017-04-26 21:21:42 PDT

Created attachment 308333 [details] Patch

Fujii Hironori

Comment 9 2017-04-26 21:51:36 PDT

Created attachment 308336 [details] screenshot of before and after this fix

WebKit Commit Bot

Comment 10 2017-04-27 08:39:37 PDT

Comment on attachment 308333 [details] Patch Clearing flags on attachment: 308333 Committed r215867: <http://trac.webkit.org/changeset/215867>

WebKit Commit Bot

Comment 11 2017-04-27 08:39:39 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.