Bug 170977

Summary:

[GTK] Web Inspector: some SVG images are specified 'currentColor' incorrectly

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

Web Inspector

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, cgarcia, commit-queue, inspector-bugzilla-changes, joepeck, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
A screenshot of before and after	none
Patch	none
Patch	none
screenshot of before and after this fix	none

Description Fujii Hironori 2017-04-18 19:30:03 PDT

[GTK] Web Inspector: some SVG images are specified 'currentColor' incorrectly

The keyword 'currentColor' is specifed manually in Bug 150602.
But, some SVG images are specified unexpectedly.

  gtk/NavigationItemCurleyBraces.svg
  gtk/NavigationItemTypes.svg
  gtk/UpDownArrows.svg

And, gtk/NavigationItemCurleyBraces.svg is licensed under NonCommercial CC (Bug 170902).
I'll recreate this image.

Comment 1 Fujii Hironori 2017-04-18 19:39:18 PDT

Created attachment 307452 [details]
Patch

Comment 2 Fujii Hironori 2017-04-18 19:40:04 PDT

Created attachment 307455 [details]
A screenshot of before and after

Comment 3 Michael Catanzaro 2017-04-18 20:15:24 PDT

Could you please split this into two patches:

 * First patch to fix currentColor
 * Second patch, in bug #170902, to replace gtk/NavigationItemCurleyBraces.svg with the new version created by you.

Thanks a bunch for fixing these issues. Also thanks for the screenshot, as that makes reviewing it much easier.

Comment 4 Fujii Hironori 2017-04-19 22:19:45 PDT

Created attachment 307553 [details]
Patch

Sure.

Comment 5 Joseph Pecoraro 2017-04-19 22:41:54 PDT

Comment on attachment 307553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307553&action=review

> Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCurleyBraces.svg:-2
> -<!-- Licensed under the Creative Commons Attribution-Share Alike 3.0 United States License (http://creativecommons.org/licenses/by-sa/3.0/) -->

This removes the license that all the others have. Unexpected?

Comment 6 Fujii Hironori 2017-04-19 23:18:41 PDT

Umm, I should address Bug 170902 before this?
Any idea, Michael?

Comment 7 Michael Catanzaro 2017-04-20 09:49:33 PDT

Please use CC-BY-SA for your new image, yes. And let's land a patch for that image in bug #170902 instead, yes. We shouldn't bury the fix for that in this issue. Perhaps you could upload a new patch here with the changes to just the other two icons.

Comment 8 Fujii Hironori 2017-04-26 21:21:42 PDT

Created attachment 308333 [details]
Patch

Comment 9 Fujii Hironori 2017-04-26 21:51:36 PDT

Created attachment 308336 [details]
screenshot of before and after this fix

Comment 10 WebKit Commit Bot 2017-04-27 08:39:37 PDT

Comment on attachment 308333 [details]
Patch

Clearing flags on attachment: 308333

Committed r215867: <http://trac.webkit.org/changeset/215867>

Comment 11 WebKit Commit Bot 2017-04-27 08:39:39 PDT

All reviewed patches have been landed.  Closing bug.