Bug 170972

Summary: Move notFound into its own file
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, joepeck, ryanhaddad, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2017-04-18 17:58:30 PDT
Move notFound into its own file
Attachments
Patch (7.36 KB, patch)
2017-04-18 18:09 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-04-18 18:09:52 PDT
Created attachment 307445 [details] Patch
WebKit Commit Bot
Comment 2 2017-04-19 10:57:56 PDT
Comment on attachment 307445 [details] Patch Clearing flags on attachment: 307445 Committed r215518: <http://trac.webkit.org/changeset/215518>
WebKit Commit Bot
Comment 3 2017-04-19 10:57:58 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 4 2017-04-19 15:05:30 PDT
This change appears to have broken the Windows build: c:\cygwin\home\buildbot\slave\win-debug\build\source\wtf\wtf\Vector.h(50): error C2953: 'WTF::VectorDestructor<false,T>': class template has already been defined (compiling source file C:\cygwin\home\buildbot\slave\win-debug\build\Source\WTF\wtf\ParkingLot.cpp) [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\WTF\wtf\WTF.vcxproj] https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/692/steps/compile-webkit/logs/stdio
Ryan Haddad
Comment 5 2017-04-19 15:07:02 PDT
Reverted r215518 for reason: This change appears to have broken the Windows build. Committed r215534: <http://trac.webkit.org/changeset/215534>
Joseph Pecoraro
Comment 6 2017-04-19 16:30:37 PDT
(In reply to Ryan Haddad from comment #4) > This change appears to have broken the Windows build: > > c:\cygwin\home\buildbot\slave\win-debug\build\source\wtf\wtf\Vector.h(50): > error C2953: 'WTF::VectorDestructor<false,T>': class template has already > been defined (compiling source file My guess is this is from moving to #pragma once and ForwardingHeaders. We've seen this before.
Sam Weinig
Comment 7 2017-04-20 12:44:34 PDT
Re-landed in r215571 without pragma changes.
Note You need to log in before you can comment on or make changes to this bug.