| Summary: | Move notFound into its own file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, joepeck, ryanhaddad, zalan | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2017-04-18 17:58:30 PDT
Created attachment 307445 [details]
Patch
Comment on attachment 307445 [details] Patch Clearing flags on attachment: 307445 Committed r215518: <http://trac.webkit.org/changeset/215518> All reviewed patches have been landed. Closing bug. This change appears to have broken the Windows build: c:\cygwin\home\buildbot\slave\win-debug\build\source\wtf\wtf\Vector.h(50): error C2953: 'WTF::VectorDestructor<false,T>': class template has already been defined (compiling source file C:\cygwin\home\buildbot\slave\win-debug\build\Source\WTF\wtf\ParkingLot.cpp) [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\WTF\wtf\WTF.vcxproj] https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/692/steps/compile-webkit/logs/stdio Reverted r215518 for reason: This change appears to have broken the Windows build. Committed r215534: <http://trac.webkit.org/changeset/215534> (In reply to Ryan Haddad from comment #4) > This change appears to have broken the Windows build: > > c:\cygwin\home\buildbot\slave\win-debug\build\source\wtf\wtf\Vector.h(50): > error C2953: 'WTF::VectorDestructor<false,T>': class template has already > been defined (compiling source file My guess is this is from moving to #pragma once and ForwardingHeaders. We've seen this before. |