Summary: | Array.prototype functions create length properties with DontEnum/DontDelete | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
Component: | JavaScriptCore | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ggaren | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 17067 | ||||||||
Attachments: |
|
Description
Darin Adler
2008-01-30 09:48:12 PST
Created attachment 18792 [details]
patch
Comment on attachment 18792 [details]
patch
It looks like this patch contains conflict markers. Maybe you could post a new one with the conflicts resolved?
Created attachment 18796 [details]
patch with whitespace-merge-conflicts resolved
When I resolved the conflict with the whitespace, I missed a couple cases and didn't recompile. Now I recompiled and re-tested.
Comment on attachment 18796 [details]
patch with whitespace-merge-conflicts resolved
While this looks great, I think it would be better to land the fix to the Array.prototype functions separate to all the other whitespace and putDirect changes, It's not necessary, but would be nice. r=me.
Committed revision 30041. |