Bug 170938

Summary: Enable optimized layer flushes on iOS
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 170851    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch
none
patch
simon.fraser: review+
patch
buildbot: commit-queue-
Archive of layout-test-results from ews117 for mac-elcapitan
none
patch none

Antti Koivisto
Reported 2017-04-18 02:47:00 PDT
Don't flush subtrees without changes on iOS either.
Attachments
patch (8.92 KB, patch)
2017-04-18 03:08 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (10.59 KB, patch)
2017-04-18 03:12 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (11.40 KB, patch)
2017-04-18 03:21 PDT, Antti Koivisto 		simon.fraser: review+
DetailsFormatted DiffDiff
patch (11.44 KB, patch)
2017-04-18 04:13 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-elcapitan (1.52 MB, application/zip)
2017-04-18 05:46 PDT, Build Bot 		no flags
Details
patch (16.93 KB, patch)
2017-04-18 09:08 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-04-18 02:55:11 PDT
<rdar://problem/31677395>
Antti Koivisto
Comment 2 2017-04-18 03:08:52 PDT
Created attachment 307365 [details] patch
Antti Koivisto
Comment 3 2017-04-18 03:12:19 PDT
Created attachment 307366 [details] patch
Antti Koivisto
Comment 4 2017-04-18 03:21:19 PDT
Created attachment 307367 [details] patch
Simon Fraser (smfr)
Comment 5 2017-04-18 03:58:50 PDT
Comment on attachment 307367 [details] patch Did layout tests detect the breakage that this is fixing?
Antti Koivisto
Comment 6 2017-04-18 04:08:57 PDT
No, we seem to have virtually no test coverage for composited scrolling.
Antti Koivisto
Comment 7 2017-04-18 04:13:28 PDT
Created attachment 307369 [details] patch
Simon Fraser (smfr)
Comment 8 2017-04-18 04:25:04 PDT
(In reply to Antti Koivisto from comment #6) > No, we seem to have virtually no test coverage for composited scrolling. We should be able to test now with UIScriptController etc. Can you make one to go along with this change?
Antti Koivisto
Comment 9 2017-04-18 05:04:47 PDT
> We should be able to test now with UIScriptController etc. Can you make one > to go along with this change? I can try!
Build Bot
Comment 10 2017-04-18 05:46:18 PDT
Comment on attachment 307369 [details] patch Attachment 307369 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3556887 New failing tests: http/tests/inspector/network/resource-sizes-network.html
Build Bot
Comment 11 2017-04-18 05:46:20 PDT
Created attachment 307378 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Antti Koivisto
Comment 12 2017-04-18 09:08:12 PDT
Created attachment 307388 [details] patch Now with test for tile creation in touch overflow scrolling
WebKit Commit Bot
Comment 13 2017-04-18 10:31:24 PDT
Comment on attachment 307388 [details] patch Clearing flags on attachment: 307388 Committed r215469: <http://trac.webkit.org/changeset/215469>
WebKit Commit Bot
Comment 14 2017-04-18 10:31:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.