Summary: | Web Inspector: Enabled state of "All Requests" XHR breakpoint not restored correctly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Matt Baker
2017-04-17 14:26:58 PDT
Created attachment 307299 [details]
Patch
Comment on attachment 307299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307299&action=review > Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:71 > + if (!this._allRequestsBreakpoint.disabled) > + this._updateXHRBreakpoint(this._allRequestsBreakpoint); r- I do not think this makes sense in DOMDebuggerManager. Workers can have "XHR"Breakpoints but they cannot have "DOM"Breakpoints. So I'd expect this in a location that would be compatible with workers. Comment on attachment 307299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307299&action=review >> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:71 >> + this._updateXHRBreakpoint(this._allRequestsBreakpoint); > > r- I do not think this makes sense in DOMDebuggerManager. > > Workers can have "XHR"Breakpoints but they cannot have "DOM"Breakpoints. So I'd expect this in a location that would be compatible with workers. Ahh, okay "DOMDebugger" is what holds all of the Web specific breakpoints (DOM, XHR, eventually Event, Timeouts, etc). I was mistaken. r=me Comment on attachment 307299 [details] Patch Clearing flags on attachment: 307299 Committed r215435: <http://trac.webkit.org/changeset/215435> All reviewed patches have been landed. Closing bug. |