Bug 170892

Summary:

[Cocoa] Move isNullFunctionPointer down into WTF

Product:

WebKit

Reporter:

mitz

Component:

Web Template Framework

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, darin, sam

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for EWS	none
Patch for EWS	none
Move the function to wtf/darwin/WeakLinking.h	sam: review+

Description mitz 2017-04-16 14:03:18 PDT

Rather than having a copy of isNullFunctionPointer() in each source file that uses it, we can put it in a WTF header.

Comment 1 mitz 2017-04-16 15:04:54 PDT

Created attachment 307241 [details]
Patch for EWS

Comment 2 mitz 2017-04-16 15:56:30 PDT

Created attachment 307244 [details]
Patch for EWS

Comment 3 mitz 2017-04-16 17:08:00 PDT

Created attachment 307250 [details]
Move the function to wtf/darwin/WeakLinking.h

Comment 4 mitz 2017-04-16 17:08:40 PDT

Not sure I picked the best place in WTF for this function.

Comment 5 Sam Weinig 2017-04-16 17:14:40 PDT

Comment on attachment 307250 [details]
Move the function to wtf/darwin/WeakLinking.h

View in context: https://bugs.webkit.org/attachment.cgi?id=307250&action=review

> Source/WTF/wtf/darwin/WeakLinking.h:27
> +

Probably worth including <type_traits> to make this compile standalone.

Comment 6 mitz 2017-04-17 13:22:40 PDT

Committed <https://trac.webkit.org/r215424>.