Bug 170890

Summary:

Web Inspector: XHR breakpoints restored from settings do not appear in the sidebar

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none

Matt Baker

Reported 2017-04-16 12:46:34 PDT

Summary: XHR breakpoints restored from settings do not appear in the sidebar. Breakpoints added from the UI appear as expected. Steps to Reproduce: 1. Open Debugger tab 2. Add an XHR breakpoint => Breakpoint added to sidebar 3. Reload the page => Breakpoint disappears Note that the breakpoint will still cause the page to break, since the problem is not in DOMDebuggerManager.

Attachments
Patch (3.14 KB, patch) 2017-04-16 12:50 PDT, Matt Baker	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (898.43 KB, application/zip) 2017-04-16 14:08 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-04-16 12:47:37 PDT

<rdar://problem/31649271>

Matt Baker

Comment 2 2017-04-16 12:50:32 PDT

Created attachment 307236 [details] Patch

Build Bot

Comment 3 2017-04-16 14:08:56 PDT

Comment on attachment 307236 [details] Patch Attachment 307236 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3547237 New failing tests: webrtc/multi-video.html

Build Bot

Comment 4 2017-04-16 14:08:57 PDT

Created attachment 307239 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Joseph Pecoraro

Comment 5 2017-04-17 12:02:38 PDT

Comment on attachment 307236 [details] Patch r=me

WebKit Commit Bot

Comment 6 2017-04-17 12:30:59 PDT

Comment on attachment 307236 [details] Patch Clearing flags on attachment: 307236 Committed r215422: <http://trac.webkit.org/changeset/215422>

WebKit Commit Bot

Comment 7 2017-04-17 12:31:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.