Summary: | consider switching all http://svn.webkit.org links to https://svn.webkit.org | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lucas Forschler <lforschler> | ||||||
Component: | Tools / Tests | Assignee: | Lucas Forschler <lforschler> | ||||||
Status: | ASSIGNED --- | ||||||||
Severity: | Normal | CC: | ap, buildbot, glenn, jmarcell, lforschler, matthew_hanson | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Lucas Forschler
2017-04-14 14:09:23 PDT
Created attachment 307149 [details]
v1patch for updating Tools folder
Attachment 307149 [details] did not pass style-queue:
ERROR: Tools/EWSTools/build-repo.sh:53: Line contains tab character. [whitespace/tab] [5]
ERROR: Tools/EWSTools/setup-commit-queue.sh:51: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 307150 [details]
v2 patch, removing previous tab.
Comment on attachment 307150 [details] v2 patch, removing previous tab. View in context: https://bugs.webkit.org/attachment.cgi?id=307150&action=review > Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:55 > - _revision_regexp = re.compile(r'^git-svn-id: http://svn.webkit.org/repository/webkit/trunk@(?P<svnid>\d+) (?P<gitid>[0-9a-f\-]{36})$', re.MULTILINE) > + _revision_regexp = re.compile(r'^git-svn-id: https://svn.webkit.org/repository/webkit/trunk@(?P<svnid>\d+) (?P<gitid>[0-9a-f\-]{36})$', re.MULTILINE) Would it make sense to support both http and https here? We are currently having problems with using https remotes in git. We will need to investigate/fix this before landing this patch. |