Summary: | webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, buildbot, commit-queue, ddkilzer, glenn, lforschler, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jonathan Bedard
2017-04-14 14:03:30 PDT
Created attachment 307145 [details]
Patch
Comment on attachment 307145 [details]
Patch
looks good to me.
Comment on attachment 307145 [details] Patch Rejecting attachment 307145 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 307145, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 1 FAILED at 50. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitpy/port/ios_device.py.rej patching file Tools/Scripts/webkitpy/port/ios_simulator.py patching file Tools/Scripts/webkitpy/port/ios_simulator_unittest.py patching file Tools/Scripts/webkitpy/port/mac.py patching file Tools/Scripts/webkitpy/port/mac_unittest.py Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Aakash Jain']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3707973 Created attachment 309552 [details]
Patch for landing
Comment on attachment 309552 [details] Patch for landing Clearing flags on attachment: 309552 Committed r216556: <http://trac.webkit.org/changeset/216556> All reviewed patches have been landed. Closing bug. |