Summary: | WebAssembly: fix windows build | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | JF Bastien <jfbastien> | ||||||||||
Component: | JavaScriptCore | Assignee: | JF Bastien <jfbastien> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, jfbastien, keith_miller, mark.lam, msaboff, rniwa, ryanhaddad, saam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 170628 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
JF Bastien
2017-04-13 15:33:05 PDT
Created attachment 307035 [details]
patch
Comment on attachment 307035 [details]
patch
Oops, deleted too much.
Created attachment 307038 [details]
patch
Fix the fix.
Comment on attachment 307038 [details]
patch
Actually this doesn't work either. Looks like the Windows build includes isIOS but others don't.
Created attachment 307039 [details]
patch
This one should work. The Windows build #if include the x86 assembler, which is why it was getting the declaration when others weren't.
Comment on attachment 307039 [details]
patch
r=me if EWS bots are happy.
(In reply to Mark Lam from comment #6) > Comment on attachment 307039 [details] > patch > > r=me if EWS bots are happy. Sadly, win-ews is offline at the moment. (In reply to Ryan Haddad from comment #7) > (In reply to Mark Lam from comment #6) > > Comment on attachment 307039 [details] > > patch > > > > r=me if EWS bots are happy. > > Sadly, win-ews is offline at the moment. I'd be happy if the remaining bots are all happy. Comment on attachment 307039 [details] patch Attachment 307039 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3531185 New failing tests: webrtc/multi-video.html Created attachment 307056 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 307039 [details]
patch
I think bots are wrong about the multi-video crash.
Comment on attachment 307039 [details] patch Clearing flags on attachment: 307039 Committed r215356: <http://trac.webkit.org/changeset/215356> All reviewed patches have been landed. Closing bug. |