Bug 170832

Summary: WebAssembly: fix windows build
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, jfbastien, keith_miller, mark.lam, msaboff, rniwa, ryanhaddad, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 170628    
Bug Blocks:    
Attachments:
Description Flags
patch
jfbastien: commit-queue-
patch
jfbastien: review-, jfbastien: commit-queue-
patch
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 none

Description JF Bastien 2017-04-13 15:33:05 PDT
Bug #170628 broke it.
Comment 1 JF Bastien 2017-04-13 15:36:09 PDT
Created attachment 307035 [details]
patch
Comment 2 JF Bastien 2017-04-13 15:39:31 PDT
Comment on attachment 307035 [details]
patch

Oops, deleted too much.
Comment 3 JF Bastien 2017-04-13 15:41:05 PDT
Created attachment 307038 [details]
patch

Fix the fix.
Comment 4 JF Bastien 2017-04-13 15:41:40 PDT
Comment on attachment 307038 [details]
patch

Actually this doesn't work either. Looks like the Windows build includes isIOS but others don't.
Comment 5 JF Bastien 2017-04-13 15:43:51 PDT
Created attachment 307039 [details]
patch

This one should work. The Windows build #if include the x86 assembler, which is why it was getting the declaration when others weren't.
Comment 6 Mark Lam 2017-04-13 15:45:37 PDT
Comment on attachment 307039 [details]
patch

r=me if EWS bots are happy.
Comment 7 Ryan Haddad 2017-04-13 16:07:07 PDT
(In reply to Mark Lam from comment #6)
> Comment on attachment 307039 [details]
> patch
> 
> r=me if EWS bots are happy.

Sadly, win-ews is offline at the moment.
Comment 8 Mark Lam 2017-04-13 16:26:23 PDT
(In reply to Ryan Haddad from comment #7)
> (In reply to Mark Lam from comment #6)
> > Comment on attachment 307039 [details]
> > patch
> > 
> > r=me if EWS bots are happy.
> 
> Sadly, win-ews is offline at the moment.

I'd be happy if the remaining bots are all happy.
Comment 9 Build Bot 2017-04-13 17:26:39 PDT
Comment on attachment 307039 [details]
patch

Attachment 307039 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3531185

New failing tests:
webrtc/multi-video.html
Comment 10 Build Bot 2017-04-13 17:26:40 PDT
Created attachment 307056 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 11 JF Bastien 2017-04-13 21:18:05 PDT
Comment on attachment 307039 [details]
patch

I think bots are wrong about the multi-video crash.
Comment 12 WebKit Commit Bot 2017-04-13 21:46:59 PDT
Comment on attachment 307039 [details]
patch

Clearing flags on attachment: 307039

Committed r215356: <http://trac.webkit.org/changeset/215356>
Comment 13 WebKit Commit Bot 2017-04-13 21:47:01 PDT
All reviewed patches have been landed.  Closing bug.