Summary: | WebAssembly: limit slow memories | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | JF Bastien <jfbastien> | ||||||||
Component: | JavaScriptCore | Assignee: | JF Bastien <jfbastien> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 170628 | ||||||||||
Bug Blocks: | 159775 | ||||||||||
Attachments: |
|
Description
JF Bastien
2017-04-13 13:42:16 PDT
Created attachment 307473 [details]
patch
Comment on attachment 307473 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=307473&action=review r=me. I'd like to at least see a test we run on Mac, and if it's flaky, we can consider what to do next. But let's land it before assuming it'll be flaky. > Source/JavaScriptCore/ChangeLog:21 > + I haven't added a test because the bots will likely be unhappy / What about at least making it run on Mac? > Source/JavaScriptCore/wasm/WasmMemory.cpp:203 > + size_t maximum = fastMemoryAllocationSoftLimit * Memory::fastMappedBytes(); I would really add a new variable for this, even if initially it's the same value. That way we can change them independent of one another. Created attachment 307488 [details]
patch
Add test and factor out function as suggested.
Comment on attachment 307488 [details] patch Rejecting attachment 307488 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 307488, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: succeeded at 1 with fuzz 3. patching file JSTests/wasm.yaml Hunk #1 FAILED at 1. Hunk #2 succeeded at 31 (offset 2 lines). 1 out of 2 hunks FAILED -- saving rejects to file JSTests/wasm.yaml.rej patching file JSTests/wasm/stress/oom.js patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/wasm/WasmMemory.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3564516 Created attachment 307489 [details]
patch
Rebase. I self-merge-conflicted.
The commit-queue encountered the following flaky tests while processing attachment 307489 [details]:
The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 307489 [details]: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: graouts@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 307489 [details] patch Clearing flags on attachment: 307489 Committed r215525: <http://trac.webkit.org/changeset/215525> All reviewed patches have been landed. Closing bug. |