|Summary:||WebAssembly: limit slow memories|
|Product:||WebKit||Reporter:||JF Bastien <jfbastien>|
|Severity:||Normal||CC:||commit-queue, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, sbarati|
|Version:||WebKit Nightly Build|
|Bug Depends on:||170628|
Description JF Bastien 2017-04-13 13:42:16 PDT
Bug #170628 limits the number of fast memories, partly because ASLR. The code then falls back to slow memories. It first tries to virtually allocated any declared maximum (and in there, physically the initial), and if that fails it tries to physically allocate the initial without any extra. This can still be used to cause a bunch of virtual allocation. We should probably impose a soft limit on slow memories as well. I think that limit should be against whole-process sum of virtually allocated slow memory (don't forget to include calls to grow!). I'm not sure what the number should be, but I'll guess something around what the maximum for fast memory virtual allocation is. Anything exceeding that limit would cause allocation/grow to fail.
Comment 2 Saam Barati 2017-04-19 09:49:49 PDT
Comment 3 JF Bastien 2017-04-19 10:31:31 PDT
Created attachment 307488 [details] patch Add test and factor out function as suggested.
Comment 4 WebKit Commit Bot 2017-04-19 10:33:30 PDT
Comment 5 JF Bastien 2017-04-19 10:39:01 PDT
Created attachment 307489 [details] patch Rebase. I self-merge-conflicted.
Comment 6 WebKit Commit Bot 2017-04-19 11:45:41 PDT
The commit-queue encountered the following flaky tests while processing attachment 307489 [details]: The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-04-19 11:45:49 PDT
The commit-queue encountered the following flaky tests while processing attachment 307489 [details]: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: firstname.lastname@example.org) The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2017-04-19 12:38:55 PDT
Comment on attachment 307489 [details] patch Clearing flags on attachment: 307489 Committed r215525: <http://trac.webkit.org/changeset/215525>
Comment 9 WebKit Commit Bot 2017-04-19 12:38:57 PDT
All reviewed patches have been landed. Closing bug.