Summary: | Fix CMake build | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alex Christensen
2017-04-13 11:33:04 PDT
Created attachment 307001 [details]
Patch
Comment on attachment 307001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307001&action=review I'm guessing this is fixing multiple build fixes? > Source/WebCore/PlatformMac.cmake:-266 > - loader/cf/SubresourceLoaderCF.cpp Is this also needed? > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-761 > - return NO; Same, is this also needed? Yep, they're both needed. They solve different problems that also prevent the CMake build from working. |