Bug 170767

Summary:

[GStreamer] Dailymotion live stream videos don't play

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, calvaris, svillar

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

169725

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Rebased patch	svillar: review+

Description Carlos Garcia Campos 2017-04-12 02:17:41 PDT

The video shows a message saying that an error occurred and nothing is played. For some reason we are getting a 404 for the hls parts.

Comment 1 Carlos Garcia Campos 2017-04-17 10:25:28 PDT

Created attachment 307275 [details]
Patch

Comment 2 Carlos Garcia Campos 2017-05-02 02:30:53 PDT

Created attachment 308811 [details]
Rebased patch

Comment 3 Sergio Villar Senin 2017-05-02 02:46:09 PDT

Comment on attachment 308811 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308811&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:909
> +        priv->redirectedURI = WTFMove(resolvedURI);

This resolved/redirected naming is a bit confusing.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:956
> +

I think this chunk of code deserves an explanation, it's pretty clear what it does but not why we need to do this.

Comment 4 Xabier Rodríguez Calvar 2017-05-02 02:58:11 PDT

Comment on attachment 308811 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308811&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1119
> +            m_resource = ResourceHandle::create(nullptr /*context*/, m_request, this, true, false);

Nit: I don't see the need of having /*context*/.

Comment 5 Carlos Garcia Campos 2017-05-02 03:06:08 PDT

Committed r216067: <http://trac.webkit.org/changeset/216067>