Bug 170758

Summary:

Modernize vector adoption

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, sam, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Alex Christensen

Reported 2017-04-11 18:26:18 PDT

Modernize vector adoption

Attachments
Patch (20.78 KB, patch) 2017-04-11 18:28 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (21.64 KB, patch) 2017-04-12 01:41 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2017-04-11 18:28:18 PDT

Created attachment 306882 [details] Patch

Sam Weinig

Comment 2 2017-04-11 19:03:10 PDT

Comment on attachment 306882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306882&action=review > Source/WebCore/platform/SharedBuffer.h:61 > + WEBCORE_EXPORT static Ref<SharedBuffer> adoptVector(Vector<char>&&); Seems like this could just be called create(Vector<char>&&)

Geoffrey Garen

Comment 3 2017-04-11 21:15:58 PDT

Comment on attachment 306882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306882&action=review r=me >> Source/WebCore/platform/SharedBuffer.h:61 >> + WEBCORE_EXPORT static Ref<SharedBuffer> adoptVector(Vector<char>&&); > > Seems like this could just be called create(Vector<char>&&) 👍 for create().

Alex Christensen

Comment 4 2017-04-12 01:41:52 PDT

Created attachment 306898 [details] Patch

WebKit Commit Bot

Comment 5 2017-04-12 02:25:08 PDT

Comment on attachment 306898 [details] Patch Clearing flags on attachment: 306898 Committed r215262: <http://trac.webkit.org/changeset/215262>

WebKit Commit Bot

Comment 6 2017-04-12 02:25:09 PDT

All reviewed patches have been landed. Closing bug.

Yusuke Suzuki

Comment 7 2017-04-12 05:16:35 PDT

Committed r215266: <http://trac.webkit.org/changeset/215266>