Bug 170754

Summary: REGRESSION: LayoutTest webrtc/negotiatedneeded-event-addStream.html is frequently crashing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

Ryan Haddad
Reported 2017-04-11 16:08:18 PDT
LayoutTest webrtc/negotiatedneeded-event-addStream.html is frequently crashing https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r215247%20(605)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fnegotiatedneeded-event-addStream.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x0000000108f2619e WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::find<WTF::IdentityHashTranslator<WTF::HashMap<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >::KeyValuePairTraits, WTF::IntHash<unsigned long long> >, unsigned long long>(unsigned long long const&) + 10 (HashTable.h:1007) 1 com.apple.WebKit 0x0000000108f24d63 WTF::HashMap<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >::take(unsigned long long const&) + 27 (HashTable.h:378) 2 com.apple.WebKit 0x0000000108f24a64 WebKit::NetworkRTCProvider::resolvedName(__CFHost*, CFHostInfoType, CFStreamError const*, void*) + 64 (memory:2721) 3 com.apple.CFNetwork 0x00007fffa5d02125 ClassicHostDelegate::hostInfoCallback(HostBase*, __CFString const*, __CFError*) + 155 4 com.apple.CFNetwork 0x00007fffa5d01b79 HostBase::invokeCallback(__CFString const*) + 155 5 com.apple.CFNetwork 0x00007fffa5d019e5 DispatchHost::processPending() + 129 6 com.apple.CoreFoundation 0x00007fffa69988d1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 7 com.apple.CoreFoundation 0x00007fffa6979be7 __CFRunLoopDoSources0 + 423 8 com.apple.CoreFoundation 0x00007fffa6979156 __CFRunLoopRun + 934 9 com.apple.CoreFoundation 0x00007fffa6978b54 CFRunLoopRunSpecific + 420 10 com.apple.Foundation 0x00007fffa83ab612 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 11 com.apple.Foundation 0x00007fffa83ab4ea -[NSRunLoop(NSRunLoop) run] + 76 12 libxpc.dylib 0x00007fffbc1d989b _xpc_objc_main + 731 13 libxpc.dylib 0x00007fffbc1d82e4 xpc_main + 494 14 com.apple.WebKit.Networking 0x0000000108e38695 main + 492 15 libdyld.dylib 0x00007fffbbf75255 start + 1
Attachments
Patch for landing (1.32 KB, patch)
2017-04-12 11:34 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-04-11 22:36:50 PDT
<rdar://problem/31573169>
youenn fablet
Comment 2 2017-04-12 11:34:08 PDT
Created attachment 306924 [details] Patch for landing
WebKit Commit Bot
Comment 3 2017-04-12 12:17:22 PDT
Comment on attachment 306924 [details] Patch for landing Clearing flags on attachment: 306924 Committed r215278: <http://trac.webkit.org/changeset/215278>
WebKit Commit Bot
Comment 4 2017-04-12 12:17:23 PDT
All reviewed patches have been landed. Closing bug.
youenn fablet
Comment 5 2017-04-12 12:31:16 PDT
Let's fix it
youenn fablet
Comment 6 2017-05-15 09:36:55 PDT
Test is no longer crashing probably to change in the way we stop resolvers.
Note You need to log in before you can comment on or make changes to this bug.