Summary: | Link preload HTMLPreloadScanner support | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yoav Weiss <yoav> | ||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, buildbot, cdumez, commit-queue, dbates, esprehn+autocc, gyuyoung.kim, japhet, youennf | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Yoav Weiss
2017-04-11 13:55:27 PDT
Created attachment 306853 [details]
Patch
Created attachment 306857 [details]
Patch
Friendly ping :) Comment on attachment 306857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306857&action=review > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:149 > + std::optional<CachedResource::Type> type = resourceType(); Use auto maybe? > LayoutTests/http/tests/preload/preloadscanner_download_resources.html:7 > + shouldBeTrue("internals.isPreloaded('../resources/dummy.js');"); Can you exit early if window.intrrnals is undefined? > LayoutTests/http/tests/preload/preloadscanner_download_resources.html:8 > + shouldBeTrue("internals.isPreloaded('../resources/dummy.css');"); Exit with a proper message.., Created attachment 308891 [details]
Patch
(In reply to youenn fablet from comment #4) > Comment on attachment 306857 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306857&action=review > > > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:149 > > + std::optional<CachedResource::Type> type = resourceType(); > > Use auto maybe? done > > > LayoutTests/http/tests/preload/preloadscanner_download_resources.html:7 > > + shouldBeTrue("internals.isPreloaded('../resources/dummy.js');"); > > Can you exit early if window.intrrnals is undefined? done > > > LayoutTests/http/tests/preload/preloadscanner_download_resources.html:8 > > + shouldBeTrue("internals.isPreloaded('../resources/dummy.css');"); > > Exit with a proper message.., Not sure what you mean, as `shouldBeTrue` has no parameter for a more meaningful message. Can you elaborate? Created attachment 308949 [details]
Patch
Comment on attachment 308949 [details]
Patch
Added a failure message when internals is not available. Thanks for reviewing! :)
Comment on attachment 308949 [details] Patch Clearing flags on attachment: 308949 Committed r216143: <http://trac.webkit.org/changeset/216143> All reviewed patches have been landed. Closing bug. |