Summary: | webkitpy: Ignore previously launched pid when system is under stress | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
Status: | RESOLVED CONFIGURATION CHANGED | ||||||||
Severity: | Critical | CC: | aakash_jain, buildbot, commit-queue, ddkilzer, dean_johnson, glenn, lforschler, ryanhaddad, webkit-bug-importer | ||||||
Priority: | P1 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jonathan Bedard
2017-04-11 11:11:06 PDT
Created attachment 306835 [details]
Patch
Comment on attachment 306835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306835&action=review r=me > Tools/Scripts/webkitpy/port/simulator_process.py:96 > + raise Exception('Faild to launch {}, kept receiving old PID'.format(os.path.basename(self._cmd[0]))) Jonathan says this should be a RuntimeException. Adding a blank space before the "try:" line would make this easier to read. Created attachment 307036 [details]
Patch for landing
Comment on attachment 307036 [details] Patch for landing Clearing flags on attachment: 307036 Committed r215346: <http://trac.webkit.org/changeset/215346> All reviewed patches have been landed. Closing bug. Follow up fix in <http://trac.webkit.org/changeset/215361>. Another follow up fix in <http://trac.webkit.org/changeset/215363>. Reverted r215363 for reason: This change causes LayoutTests to exit early with crashes. Committed r215367: <http://trac.webkit.org/changeset/215367> Addressed Ryan's rollout in <http://trac.webkit.org/changeset/215374>. Reverted r215374 for reason: This change causes LayoutTests to exit early with crashes on Sierra. Committed r215380: <http://trac.webkit.org/changeset/215380> If <https://trac.webkit.org/changeset/215416/webkit> fixes this problem, I will roll-out all of the other changes. I think <https://trac.webkit.org/changeset/215416/webkit> is the root cause. Reverted r215346 and r215361 for reason: The problem these changes were fixing was addressed in <https://trac.webkit.org/changeset/215416/webkit>. Committed r215470: <http://trac.webkit.org/changeset/215470> |