| Summary: | Add a preference for the media resource buffering time | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | sam | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2017-04-11 10:50:43 PDT
Created attachment 306833 [details]
Patch
Comment on attachment 306833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306833&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:590 > +- (double)_mediaResourceMaximumBufferingTime I think the suffix Duration, rather than Time, would be better. > Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:251 > + parameters.mediaResourceMaximumBufferingTime = Seconds(m_defaultPageGroup->preferences().mediaResourceMaximumBufferingTime()); Seems weird/wrong to have webpreferences affect WebProcess creation, since a single web process can have web pages with different webpreferences. It also looks like you aren't handling the preference changing after the process is created. I agree that it's icky, but this is a consequence of the WebResourceLoader being process global in the WebProcess. And it's only temporary, so I'll remove it soon. I'll change the suffix, though. Created attachment 306843 [details]
Patch
Created attachment 306851 [details]
Patch
Comment on attachment 306851 [details]
Patch
This patch is a step in the wrong direction, but it will allow me to do local testing easier.
|