Bug 170696

Summary: Have parseRevisionProperty use default repo name as the buildbot key.
Product: WebKit Reporter: Kocsen Chung <kocsen_chung>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, kocsen_chung, lforschler, thorton, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kocsen Chung
Reported 2017-04-10 15:08:38 PDT
Have parseRevisionProperty use default repo name as the buildbot key.
Attachments
Patch (2.51 KB, patch)
2017-04-10 15:13 PDT, Kocsen Chung 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2017-04-10 17:01 PDT, Kocsen Chung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kocsen Chung
Comment 1 2017-04-10 15:13:05 PDT
Created attachment 306749 [details] Patch
Daniel Bates
Comment 2 2017-04-10 16:23:23 PDT
Comment on attachment 306749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306749&action=review > Tools/ChangeLog:9 > + buildobt data. That is no longer necessary as we can make a safe assumption buildobt => Buildbot > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:208 > + var key = repositoryName; Instead of default initializing these variables and then overwriting them for OpenSiurce I suggest that we leave them hninitialized here and remove the "else if" For Internal.
Kocsen Chung
Comment 3 2017-04-10 17:01:23 PDT
Created attachment 306759 [details] Patch
Kocsen Chung
Comment 4 2017-04-10 17:12:04 PDT
Comment on attachment 306759 [details] Patch Thanks Dan, for the review. commit-queue ?
WebKit Commit Bot
Comment 5 2017-04-10 20:34:00 PDT
Comment on attachment 306759 [details] Patch Clearing flags on attachment: 306759 Committed r215215: <http://trac.webkit.org/changeset/215215>
WebKit Commit Bot
Comment 6 2017-04-10 20:34:02 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 7 2017-04-10 20:44:40 PDT
I've updated the buildbot repo as of 8:45 pacific time.
Note You need to log in before you can comment on or make changes to this bug.