Bug 170695

Summary:

Retrying an A/B testing does not set the repetition count in some cases

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, joepeck, rniwa

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	joepeck: review+

Ryosuke Niwa

Reported 2017-04-10 14:51:52 PDT

When retrying or creating a new new A/B testing, changing the repetition change from the default 4 has no effect.

Attachments
Fixes the bug (6.51 KB, patch) 2017-04-10 15:01 PDT, Ryosuke Niwa	joepeck: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2017-04-10 15:01:14 PDT

Joseph Pecoraro

Comment 2 2017-04-10 15:04:17 PDT

Comment on attachment 306748 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=306748&action=review r=me > Websites/perf.webkit.org/browser-tests/test-group-form-tests.js:1 > + Normal to have an empty line?

Ryosuke Niwa

Comment 3 2017-04-10 17:02:08 PDT

Comment on attachment 306748 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=306748&action=review Thanks for the review! >> Websites/perf.webkit.org/browser-tests/test-group-form-tests.js:1 >> + > > Normal to have an empty line? Yeah, almost every test starts with a blank line.

Ryosuke Niwa

Comment 4 2017-04-11 21:37:40 PDT

Note You need to log in before you can comment on or make changes to this bug.