Bug 170695 - Retrying an A/B testing does not set the repetition count in some cases
Summary: Retrying an A/B testing does not set the repetition count in some cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-10 14:51 PDT by Ryosuke Niwa
Modified: 2017-04-11 21:37 PDT (History)
3 users (show)

See Also:

Attachments
Fixes the bug (6.51 KB, patch)
2017-04-10 15:01 PDT, Ryosuke Niwa 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-04-10 14:51:52 PDT 
When retrying or creating a new new A/B testing, changing the repetition change from the default 4 has no effect.
Comment 1 Ryosuke Niwa 2017-04-10 15:01:14 PDT 
Created attachment 306748 [details]
Fixes the bug
Comment 2 Joseph Pecoraro 2017-04-10 15:04:17 PDT 
Comment on attachment 306748 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=306748&action=review

r=me

> Websites/perf.webkit.org/browser-tests/test-group-form-tests.js:1
> +

Normal to have an empty line?
Comment 3 Ryosuke Niwa 2017-04-10 17:02:08 PDT 
Comment on attachment 306748 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=306748&action=review

Thanks for the review!

>> Websites/perf.webkit.org/browser-tests/test-group-form-tests.js:1
>> +
> 
> Normal to have an empty line?

Yeah, almost every test starts with a blank line.
Comment 4 Ryosuke Niwa 2017-04-11 21:37:40 PDT 
Committed r215257: <http://trac.webkit.org/changeset/215257>