Summary: | WebAssembly: report Memory usage to GC | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | JF Bastien <jfbastien> | ||||
Component: | JavaScriptCore | Assignee: | JF Bastien <jfbastien> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 170628 | ||||||
Bug Blocks: | 159775 | ||||||
Attachments: |
|
Description
JF Bastien
2017-04-10 13:42:42 PDT
Created attachment 309699 [details]
patch
I'm still not sure this is the right thing. We definitely should tell the GC about this memory but:
1. It's more memory than other allocations. Maybe that's the same as ArrayBuffer and doesn't matter?
2. We're not sure all pages are dirty, so we could be over-reporting if the developer over-allocates. We just don't know if they do.
I think these don't matter, and we can adjust if they do, so this patch is probably right. I'd nonetheless would rather ask and get feedback on these points.
Comment on attachment 309699 [details]
patch
r=me.
Comment on attachment 309699 [details] patch Clearing flags on attachment: 309699 Committed r216911: <http://trac.webkit.org/changeset/216911> All reviewed patches have been landed. Closing bug. |