| Summary: | REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||
| Component: | Tools / Tests | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, lforschler, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Wenson Hsieh
2017-04-10 09:14:20 PDT
Created attachment 306691 [details]
Patch
Created attachment 306692 [details]
Patch
Comment on attachment 306692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306692&action=review > LayoutTests/fast/events/drag-to-navigate.html:1 > +<!-- webkit-test-runner [ enableDragDestinationActionLoad=true ] --> Technically no reason this needs to be a thing like this, could just be JS API (doesn't need to be known before load) but ... I guess it's OK? Comment on attachment 306692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306692&action=review >> LayoutTests/fast/events/drag-to-navigate.html:1 >> +<!-- webkit-test-runner [ enableDragDestinationActionLoad=true ] --> > > Technically no reason this needs to be a thing like this, could just be JS API (doesn't need to be known before load) but ... I guess it's OK? True, but I think in this case, TestOptions are appropriate since there aren't really cases where this behavior needs to change at runtime (i.e. it's more like a configuration or initialization param rather than a behavior to be performed). Created attachment 306699 [details]
Patch for landing
Comment on attachment 306699 [details] Patch for landing Rejecting attachment 306699 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 306699, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/3512117 Created attachment 306701 [details]
Patch for landing
Comment on attachment 306701 [details] Patch for landing Clearing flags on attachment: 306701 Committed r215189: <http://trac.webkit.org/changeset/215189> |